Changeset 78e3575 for src/mvc

Timestamp:

02/03/10 14:19:18 (12 years ago)

Author:

timkoma <timkoma@…>

Branches:

master, qt5

Children:

a1755df

Parents:

e296dc6

Message:

performance improvement for load persons

Location:

src/mvc

Files:

• event.cpp (modified) (1 diff)
• event.h (modified) (2 diffs)

src/mvc/event.cpp

@@ -144 +144 @@
 }
 
-QStringList Event::persons() const
-{
-    QSqlQuery query;
-    // TODO: conference ID isn't used here
-    query.prepare("SELECT person.name FROM person INNER JOIN event_person ON person.id = event_person.xid_person AND event_person.xid_event = :id");
-    query.bindValue(":id", id());
-    query.exec();
-    // TODO: handle qeury error
-    //qDebug() << query.lastError();
-
-    QStringList persons;
-    while(query.next())
-        persons.append(query.record().value("name").toString());
-
-    return persons;
+QStringList Event::persons()
+{
+    if( personsList.isEmpty() )
+    {
+        QSqlQuery query;
+        // TODO: conference ID isn't used here
+        query.prepare("SELECT person.name FROM person INNER JOIN event_person ON person.id = event_person.xid_person AND event_person.xid_event = :id");
+        query.bindValue(":id", id());
+        query.exec();
+        // TODO: handle qeury error
+        //qDebug() << query.lastError();
+
+        while(query.next())
+            personsList.append(query.record().value("name").toString());
+    }
+
+    return personsList;
 }
 

src/mvc/event.h

@@ -66 +66 @@
     QString room() const;
     int roomId() const;
-    QStringList persons() const;
+    QStringList persons();
     QMap<QString,QString> links() const;
 
@@ -89 +89 @@
 
 friend class EventTest;
+
+private:
+    QStringList personsList;
 };