Changeset c8c414f in confclerk_git for src/gui

Timestamp:

04/22/10 17:10:46 (13 years ago)

Author:

kirilma <kirilma@…>

Branches:

master, qt5

Children:

f299a08

Parents:

f7dc75a

Message:

optimization

Location:

src/gui

Files:

• mainwindow.cpp (modified) (6 diffs)
• mainwindow.h (modified) (1 diff)

src/gui/mainwindow.cpp

@@ -109 +109 @@
 
     useConference(Conference::activeConference());
+    // optimization, see useConference() code
+    try {
+        initTabs();
+    } catch (OrmException) {
+        clearTabs();
+    }
 
     #if 0
@@ -254 +260 @@
     try {
         Conference::getById(Conference::activeConference()).update("active",0);
-        Conference::getById(id).update("active",1);
-
-        initTabs();
+        Conference new_active = Conference::getById(id);
+        new_active.update("active",1);
+
+        // looks like it does not work at n900
+        setWindowTitle(new_active.title());
+
+        // optimization.
+        // dont run initTabs() here
+        // it takes much CPU, making travelling between conferences in ConferenceEditor longer
+        // and is not seen in maemo WM anyway
+        // instead run it explicitly where needed
+        // dont forget to protect the calls by try-catch!
+
+        // just in case, clear conference selection instead
+        clearTabs();
+
+        // end of optimization
+        // initTabs();
     } catch (OrmException& e) {
         // cannon set an active conference
@@ -271 +292 @@
     QDate startDate = active.start();
     QDate endDate = active.end();
-    setWindowTitle(active.title());
 
     // 'dayNavigator' emits signal 'dateChanged' after setting valid START:END dates
@@ -283 +303 @@
 }
 
-void MainWindow::unsetConference()
+void MainWindow::clearTabs()
 {
     dayTabContainer->clearModel();
@@ -292 +312 @@
     searchTabContainer->searchAgainClicked();
     nowTabContainer->clearModel();
-
-    // TODO:  remove
-    // conferenceHeader->hide();
+}
+
+void MainWindow::unsetConference()
+{
+    clearTabs();
     setWindowTitle(saved_title);
 }
@@ -345 +367 @@
 
     dialog.exec();
+
+    // optimization, see useConference() code
+    try {
+        initTabs();
+    } catch (OrmException) {
+        clearTabs();
+    }
 }
 

src/gui/mainwindow.h

@@ -60 +60 @@
     void fillAndShowConferenceHeader();
     void initTabs();
+    void clearTabs();
     void importData(const QByteArray &aData, const QString& url);